fix(genai): VideoGenerationIT/ ImageGenerationIT bucket & Cleanup Fixes - #10334
Draft
Kef131 wants to merge 3 commits into
Draft
fix(genai): VideoGenerationIT/ ImageGenerationIT bucket & Cleanup Fixes#10334Kef131 wants to merge 3 commits into
VideoGenerationIT/ ImageGenerationIT bucket & Cleanup Fixes#10334Kef131 wants to merge 3 commits into
Conversation
product-auto-label
Bot
added
the
samples
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates VideoGenerationIT.java to retrieve the bucket name from an environment variable with a fallback default, and wraps the test cleanup logic in a try-catch block to handle exceptions gracefully. The reviewer suggested sanitizing the BUCKET_NAME environment variable to strip any accidental gs:// prefix, which prevents potential Storage SDK failures and makes the tests more robust.
…cated Imagen tests in ImageGenerationIT
Kef131
force-pushed
the
fix-genai-videogeneration-bucket-cleanup
branch
from
August 24, 2026 22:29
3c4fa5a to
3921d9c
Compare
Kef131
changed the title
VideoGenerationIT Bucket & Cleanup FixesVideoGenerationIT/ ImageGenerationIT. Bucket & Cleanup Fixes
Kef131
changed the title
VideoGenerationIT/ ImageGenerationIT. Bucket & Cleanup FixesVideoGenerationIT/ ImageGenerationIT bucket & Cleanup Fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
b/549909475
BUCKET_NAMEenvironment variable (System.getenv().getOrDefault("BUCKET_NAME", "java-docs-samples-testing")).@AfterClass cleanup()method in atry-catchblock to prevent build failure during teardown if bucket cleanup fails or permissions are restricted.Checklist
Testing
mvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory onlyCompliance & Style
pom.xmlparent set to latestshared-configurationPost-Approval Actions